1036339 - (soft-home-button) [meta] Software home button improvements for 2.1

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Etienne Segonzac (:etienne)]

The spec is still in the work, but we already have some code :)
So tracking...

Comment 1

[Michael Henretty [:mikehenrty][:mhenretty]]

Attachment: [2.1 Spec] Soft-home button

Adding the spec for reference.

Comment 2

[Eric Chang [:ericcc] [:echang]]

Test cases not yet finished
https://moztrap.mozilla.org/manage/cases/?pagenumber=1&pagesize=100&sortfield=created_on&sortdirection=desc&filter-tag=2997

Comment 3

[Peter Dolanjski [:pdol]]

Removing feature-b2g:2.1 since this is a meta bug.

Comment 4

[Peter La]

Attachment: VsD_Soft_Home_Button_Specification.pdf

Note: the decision to go with a dot or the normal ring shaped icon is pending a review of Markus' demo videos.

Comment 5

[Peter La]

Attachment: VsD_Soft_Home_Button_Specification_20140828_V1.0.pdf

Updated Spec with final recommendation to go with ring shaped home button icon in all cases.

Comment 6

[Jason Smith [:jsmith]]

Mike - Is this feature completely landed at this point for 2.1? Or do we have anything left here? Just want to know if we can close this out as feature landed for 2.1 at this point.

Comment 7

[Michael Henretty [:mikehenrty][:mhenretty]]

Yup, this can be closed. The rest is polish and bug fixes.

Comment 8

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

The Home button does remain in the proper area when the user is in landscape or portait mode. The SHB is not covered up when transitioning between apps using edge gestures while using different orientations.

However, I cannot verify this bug as fixed.

Several issues still exist, as outlined in the Spec sheet, and PDF attached to this bug.

-The SHB does not highlight blue when it is tapped on. 
-The SHB does not become transparent on the lockscreen. 
-The SHB does not dissapear when viewing a fullscreen video. https://bugzilla.mozilla.org/show_bug.cgi?id=1055198

Comment 9

[KTucker [:KTucker][Inactive 3/4/2016]]

The SHB not highlighting blue when tapped on seems minor and not a blocker. 

The home button appearing on the lockscreen as stated in bug 1064595 to me is a blocker.

The SHB does not hide when apps have a full screen layout and when viewing videos and photos in full screen. I think is a blocker as well. See bug 1037279 bug 1055198 bug 1064327

This issue cannot be verified as fixed.

Comment 10

[Jason Smith [:jsmith]]

Discussed comment 9 with Mike - the fullscreen bugs are Flame-specific, which won't reproduce on Tako. As such, we aren't going to block on those issues for 2.1. There is agreement that bug 1064595 should be a blocker though, which means this feature did not pass FL signoff. We need bug 1064595 fixed to achieve FL signoff of this feature.

Comment 11

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

Verifying this as implemented for Flame 2.2(319mb)(Master)

The Home button does remain in the proper area when the user is in landscape or portait mode. The SHB is not covered up when transitioning between apps using edge gestures while using different orientations.

-The SHB does become transparent on the lockscreen. 

I am unable to verify this Feature as landed, due to the SHB still showing up on the lockscreen. Bug 1064595 has not been uplifted to 2.1 yet.

Flame 2.2 (319mb)

Environmental Variables:
Device: Flame Master
Build ID: 20140915040203
Gaia: 855be6ade407c26e0596e7306a44deebc3f60933
Gecko: f27ff178807d
Version: 35.0a1 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0


Flame 2.1 (319mb)

Environmental Variables:
Device: Flame Master
BuildID: 20140915000203
Gaia: 944e5b4582c4efa1b67cd33245dbb8f6aa25d09f
Gecko: 7546fedad918
Version: 34.0a2 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 12

[Jason Smith [:jsmith]]

Derek - Why is this marked verified with bug 1067441 open?

Comment 13

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

Bug 1067441 is blocking verification of this bug

Comment 14

[Tony Chung [:tchung]]

derek, please verifyme against the dependency bugs on this list, now that bug 1067441 was fixed awhile ago.

Comment 15

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

I will attempt to verify this bug on tomorrows nightly build. Cannot verify this bug as fixed until bug 1079525 has been verified first.

Comment 16

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

Besides bug 1077579 (which is just a tracking bug), all depends on of this bug have been verified fixed. Also all issues mentioned in comment 8 and comment 11 are verified fixed. Marking this bug as verified fixed for Flame 2.1 and Flame 2.2


Flame 2.2 Master KK (319mb) (Full Flash)

Device: Flame 2.2 Master
BuildID: 20141011040204
Gaia: 95f580a1522ffd0f09302372b78200dab9b6f322
Gecko: 3f6a51950eb5
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0


Flame 2.1 KK (319mb) (Full Flash)

Device: Flame 2.1
BuildID: 20141011000201
Gaia: f5d4ff60ffed8961f7d0380ada9d0facfdfd56b1
Gecko: d813d79d3eae
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0